Adding Word Limit validation - #2
Merged
Merged
Conversation
chouinar
reviewed
Aug 3, 2026
chouinar
reviewed
Aug 6, 2026
chouinar
left a comment
chouinar
left a comment
Collaborator
There was a problem hiding this comment.
To make this code available, we'll need to create & publish a new version.
For your PR, you'll just need to run make bump-patch-version which should update the pyproject & uv.lock file. After your PR is merged, we just need to run the github action that'll publish it to https://pypi.org/project/grants-shared/#description - and then we can update the dependency we import in the given service.
chouinar
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WordLimit support to validators.
Context for reviewers
Uses a similar structure to Length, but applies to words rather than character count. Uses a
/\s+/regex to identity words.